#1773 closed enhancement (fixed)
Tag items should be annotatable
Reported by: | Nicklas Nordborg | Owned by: | olle |
---|---|---|---|
Priority: | major | Milestone: | BASE 3.3 |
Component: | core | Version: | |
Keywords: | Cc: |
Description
Change History (8)
comment:1 by , 11 years ago
Owner: | changed from | to
---|
comment:2 by , 11 years ago
Status: | new → assigned |
---|
comment:3 by , 11 years ago
comment:4 by , 11 years ago
Design discussion:
- The design for this update will be based on that for Ticket #1771 (Hardware items should be annotatable) and Ticket #1772 (Software items should be annotatable). Since Tags are BioMaterials, a difference is that scripts for inspecting and editing Tag annotations are found in directory
base3/www/biomaterials/tags/
, instead ofbase3/www/admin/*/
, as is the case for Software and Hardware items. - Support for annotatable Tag items will include the following parts:
a. Basic support for adding annotations to Tag items.
b. Adding an "Annotations
" tab to the page for inspecting a Tag item, and displaying the annotations.
c. Adding an "Annotations
" tab to the edit dialog for a Tag item, and making it possible to edit annotations.
d. For an item that can have an attached Tag item, making annotations to the latter appear in the tree node for the overview of that item.
e. For an item that can have an attached Tag item, making annotations to the latter appear in the "Inherited annotations
" tab of the edit dialog for that item.
- Normally the database schema version should also be updated, since step (a.) above adds new database columns. However, this will not be done here, as the database schema version has already been updated in connection with making Hardware items annotatable in Ticket #1771, and that change will be included in the same release as this one. (The same procedure was followed for Ticket #1772, when making Software items annotatable.)
comment:5 by , 11 years ago
Design implementation:
The different parts in adding support for annotatable Tag items will involve updates to the following files:
- Basic support for adding annotations to Tag items:
Tag.java
inbase3/src/core/net/sf/basedb/core/
andTagData.java
inbase3/src/core/net/sf/basedb/core/data/
.
- Adding an "
Annotations
" tab to the page for inspecting a Tag item, and displaying the annotations:
JavaScripttags.js
inbase3/www/biomaterials/tags/
JSP scriptlist_tags.jsp
inbase3/www/biomaterials/tags/
JSP scriptview_tag.jsp
inbase3/www/biomaterials/tags/
- Adding an "
Annotations
" tab to the edit dialog for a Tag item, and making it possible to edit annotations:
JSP scriptedit_tag.jsp
inbase3/www/biomaterials/tags/
JavaScripttags.js
inbase3/www/biomaterials/tags/
JSP scriptindex.jsp
inbase3/www/biomaterials/tags/
JavaScriptmain.js
inbase3/www/include/scripts/
(for making edit dialog larger).
- For an item that can have an attached Tag item, making annotations to the latter appear in the tree node for the overview of that item:
TagLoader.java
inbase3/src/core/net/sf/basedb/util/overview/loader/
- For an item that can have an attached Tag item, making annotations to the latter appear in the "
Inherited annotations
" tab of the edit dialog for that item:Extract.java
inbase3/src/core/net/sf/basedb/core/
JavaScriptextracts.js
inbase3/www/biomaterials/extracts/
comment:7 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Ticket closed as the requested functionality has been added.
comment:8 by , 11 years ago
(In [6362]) Refs #1773. Page for inspecting a Tag item updated by adding a "Change history" tab, and displaying the changes:
- JavaScript
tags.js
inbase3/www/biomaterials/tags/
updated in functioninitPage()
forpageId
equal toview-page
to add a tab active listener for history data. - JSP script
view_tags.jsp
inbase3/www/biomaterials/tags/
updated in HTML section to add a "Change history" tab.
Note:
See TracTickets
for help on using tickets.
Ticket accepted.