#1771 closed enhancement (fixed)
Hardware items should be annotatable
Reported by: | Nicklas Nordborg | Owned by: | olle |
---|---|---|---|
Priority: | major | Milestone: | BASE 3.3 |
Component: | core | Version: | |
Keywords: | Cc: |
Description
Change History (11)
comment:3 by , 11 years ago
Traceability note:
- Ticket #1310 (Annotations for protocols) covers making Protocol items annotatable.
comment:4 by , 11 years ago
Design discussion:
- The design for this update will be based on that for Ticket #1310 (Annotations for protocols). Code changes related to making Hardware items annotatable and changing schema version can be made analogously to the latter ticket, while later changes in the GUI design only make parts of the corresponding code changes for Ticket #1310 relevant to the current case.
- Support for annotatable Hardware items will include the following parts:
a. Basic support for adding annotations to Hardware items.
b. Update of database schema version, since step (a.) adds new database columns.
c. Adding an "Annotations
" tab to the page for inspecting a Hardware item, and displaying the annotations.
d. Adding an "Annotations
" tab to the edit dialog for a Hardware item, and making it possible to edit annotations.
e. For an item that can have an attached Hardware item, making annotations to the latter appear in the tree node for the overview of that item.
f. For an item that can have an attached Hardware item, making annotations to the latter appear in the "Inherited annotations
" tab of the edit dialog for that item.
comment:5 by , 11 years ago
Design implementation:
The different parts in adding support for annotatable Hardware items will involve updates to the following files:
- Basic support for adding annotations to Hardware items:
Hardware.java
inbase3/src/core/net/sf/basedb/core/
andHardwareData.java
inbase3/src/core/net/sf/basedb/core/data/
.
- Update of database schema version:
Install.java
inbase3/src/core/net/sf/basedb/core/
andUpdate.java
inbase3/src/core/net/sf/basedb/core/
.
- Adding an "
Annotations
" tab to the page for inspecting a Hardware item, and displaying the annotations:
JavaScripthardware.js
inbase3/www/admin/hardware/
JSP scriptlist_hardware.jsp
inbase3/www/admin/hardware/
JSP scriptview_hardware.jsp
inbase3/www/admin/hardware/
- Adding an "
Annotations
" tab to the edit dialog for a Hardware item, and making it possible to edit annotations:
JSP scriptedit_hardware.jsp
inbase3/www/admin/hardware/
JavaScripthardware.js
inbase3/www/admin/hardware/
JSP scriptindex.jsp
inbase3/www/admin/hardware/
JavaScriptmain.js
inbase3/www/include/scripts/
(for making edit dialog larger).
- For an item that can have an attached Hardware item, making annotations to the latter appear in the tree node for the overview of that item:
HardwareLoader.java
inbase3/src/core/net/sf/basedb/util/overview/loader/
- For an item that can have an attached Hardware item, making annotations to the latter appear in the "
Inherited annotations
" tab of the edit dialog for that item:DerivedBioAssay.java
inbase3/src/core/net/sf/basedb/core/
JavaScriptbioassays.js
inbase3/www/views/derivedbioassays/
PhysicalBioAssay.java
inbase3/src/core/net/sf/basedb/core/
JavaScriptbioassays.js
inbase3/www/views/physicalbioassays/
comment:7 by , 11 years ago
comment:8 by , 11 years ago
comment:9 by , 11 years ago
comment:10 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Ticket closed as the requested functionality has been added.
comment:11 by , 11 years ago
(In [6360]) Refs #1771. Page for inspecting a Hardware item updated by adding a "Change history" tab, and displaying the changes:
- JavaScript
hardware.js
inbase3/www/admin/hardware/
updated in functioninitPage()
forpageId
equal toview-page
to add a tab active listener for history data. - JSP script
view_hardware.jsp
inbase3/www/admin/hardware/
updated in HTML section to add a "Change history" tab.
Note:
See TracTickets
for help on using tickets.