Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#1343 closed enhancement (fixed)

Redesign Metadata.getPropertyValue()

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: major Milestone: BASE 2.15
Component: core Version:
Keywords: Cc:

Description

Part of #1324.

The code in the mentioned method is not pretty and it is hard to maintain if new functionality is needed.

Change History (6)

comment:1 Changed 13 years ago by Nicklas Nordborg

(In [4993]) References #1324, #1343: Check TODO markers in the BASE code

comment:2 Changed 12 years ago by Nicklas Nordborg

Milestone: BASE 2.x+BASE 2.15
Owner: changed from everyone to Nicklas Nordborg
Priority: trivialmajor
Status: newassigned

I think we need this to avoid the need to hard-code property/field names for the BFS exporter used in ticket #1443. It would a lot more flexible to be able to do this dynamically and we don't have to worry about the exporter if we add more properties in the future.

I am thinking that we should replace the Metadata.getPropertyValue() method with a Metadata.getPropertyPath() method that returns an object that knows how to extract the value we are looking for without having to work it's way up the path using metadata and class type for every item.

comment:3 Changed 12 years ago by Nicklas Nordborg

(In [5293]) References #1343: Redesign Metadata.getPropertyValue()

The core of the functionality is implemented. Some details and property types (eg. collections) remains to be implemented. Methods that use the old method also needs to be fixed.

comment:4 Changed 12 years ago by Nicklas Nordborg

(In [5299]) References #1343: Redesign Metadata.getPropertyValue()

Removed all use of the deprecated Metadata.getPropertyValue() method. There are major changes in the table exporter (SimpleExport?.java) and it's helper classes so I hope I have not broken any special case on some page.

comment:5 Changed 12 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

(In [5306]) Fixes #1343: Redesign Metadata.getPropertyValue()

comment:6 Changed 12 years ago by Nicklas Nordborg

(In [5307]) References #1343: Redesign Metadata.getPropertyValue()

Removed debug output.

Note: See TracTickets for help on using tickets.