Opened 15 years ago

Closed 15 years ago

#1324 closed task (fixed)

Check TODO markers in the BASE code

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: major Milestone: BASE 2.13
Component: core Version:
Keywords: Cc:

Description

There are many places in the BASE code that has been marked with TODO. It is time to have a complete check and get rid of the TODO markers. Things that needs to be fixed should be added as tickets.

Change History (33)

comment:1 by Nicklas Nordborg, 15 years ago

Owner: changed from everyone to Nicklas Nordborg
Status: new → assigned

comment:2 by Nicklas Nordborg, 15 years ago

(In [4979]) References #1324: Check TODO markers in the BASE code

Documented 'file' parameter in TestAnalyzePluginUtil

comment:3 by Nicklas Nordborg, 15 years ago

(In [4980]) References #1324: Check TODO markers in the BASE code

Removed a planned call to test_merge_bioassays(). There is a different test program for this.

comment:4 by Nicklas Nordborg, 15 years ago

(In [4981]) References #1324: Check TODO markers in the BASE code

Removed comments from AbstractQuery. Indicated methods will only be implemented if they are needed.

comment:5 by Nicklas Nordborg, 15 years ago

(In [4982]) References #1324: Check TODO markers in the BASE code

We will probably never get any image files.

comment:6 by Nicklas Nordborg, 15 years ago

(In [4983]) References #1324: Check TODO markers in the BASE code

No global permission is needed.

comment:7 by Nicklas Nordborg, 15 years ago

(In [4984]) References #1324: Check TODO markers in the BASE code

Documented the ItemContext.getSortOrder() method.

comment:8 by Nicklas Nordborg, 15 years ago

(In [4985]) References #1324: Check TODO markers in the BASE code

Better estimated job execution time is already a ticket: #791

comment:9 by Nicklas Nordborg, 15 years ago

(In [4986]) References #1324: Check TODO markers in the BASE code

Seems like we don't need any more ways to get the result.

comment:10 by Nicklas Nordborg, 15 years ago

(In [4987]) References #1324: Check TODO markers in the BASE code

The existing examples should be enough for now.

comment:11 by Nicklas Nordborg, 15 years ago

(In [4988]) References #1324: Check TODO markers in the BASE code

Seems like we don't need any more alternatives.

comment:12 by Nicklas Nordborg, 15 years ago

(In [4989]) References #1324: Check TODO markers in the BASE code

There are no plans to support advanced filter formulas.

comment:13 by Nicklas Nordborg, 15 years ago

(In [4990]) References #1324: Check TODO markers in the BASE code

Seems like we don't need an alternate implementation.

comment:14 by Nicklas Nordborg, 15 years ago

(In [4991]) References #1324: Check TODO markers in the BASE code

Don't see any reason to replace the maps.

comment:15 by Nicklas Nordborg, 15 years ago

(In [4992]) References #1324: Check TODO markers in the BASE code

We have made it this far with the validation (which may be expensive).

comment:16 by Nicklas Nordborg, 15 years ago

(In [4993]) References #1324, #1343: Check TODO markers in the BASE code

comment:17 by Nicklas Nordborg, 15 years ago

(In [4994]) References #1324, #1336: Check TODO markers in the BASE code

comment:18 by Nicklas Nordborg, 15 years ago

(In [4995]) References #1324, #1342: Check TODO markers in the BASE code

comment:19 by Nicklas Nordborg, 15 years ago

(In [4996]) References #1324, #1340: Check TODO markers in the BASE code

comment:20 by Nicklas Nordborg, 15 years ago

(In [4997]) References #1324: Check TODO markers in the BASE code

Mapping is only done to raw data spots.

comment:21 by Nicklas Nordborg, 15 years ago

(In [4998]) References #1324: Check TODO markers in the BASE code

Better estimated job execution time is already a ticket: #791

comment:22 by Nicklas Nordborg, 15 years ago

(In [4999]) References #1324: Check TODO markers in the BASE code

Plug-in configuration is described in the docbook documentation.

comment:23 by Nicklas Nordborg, 15 years ago

(In [5000]) References #1324: Check TODO markers in the BASE code

There are no image files.

comment:24 by Nicklas Nordborg, 15 years ago

(In [5001]) References #1324: Check TODO markers in the BASE code

Seems to work.

comment:25 by Nicklas Nordborg, 15 years ago

(In [5002]) References #1324: Check TODO markers in the BASE code

It is unclear what should be updated, and the current code seems to work.

comment:26 by Nicklas Nordborg, 15 years ago

(In [5003]) References #1324: Check TODO markers in the BASE code

I guess we'll have to stick with this.

comment:27 by Nicklas Nordborg, 15 years ago

(In [5004]) References #1324, #1341: Check TODO markers in the BASE code

comment:28 by Nicklas Nordborg, 15 years ago

(In [5005]) References #1324, #1320: Check TODO markers in the BASE code

comment:29 by Nicklas Nordborg, 15 years ago

(In [5006]) References #1324, #1338: Check TODO markers in the BASE code

comment:30 by Nicklas Nordborg, 15 years ago

(In [5007]) References #1324, #1339: Check TODO markers in the BASE code

comment:31 by Nicklas Nordborg, 15 years ago

(In [5008]) References #1324, #1337: Check TODO markers in the BASE code

comment:32 by Nicklas Nordborg, 15 years ago

(In [5009]) References #1324, #1344: Check TODO markers in the BASE code

comment:33 by Nicklas Nordborg, 15 years ago

Resolution: → fixed
Status: assigned → closed

All TODO markers have been removed and replaced with new tickets.

Note: See TracTickets for help on using tickets.