Opened 16 years ago

Closed 15 years ago

#567 closed enhancement (fixed)

jdk6 (1.6.0) compatibility

Reported by: base Owned by: Nicklas Nordborg
Priority: critical Milestone: BASE 2.4
Component: core Version:
Keywords: Cc:

Description

We were compiling the source with jdk1.6.0 with no problems up to BASE 2.2.1 then one error and one warning appeared in 2.2.2. I fixed them, but you'll want to have a closer look. I'm not very happy with the findConstructor() fix, and don't know Java and reflection well enough to do a proper job.

Diffs attached

(VectorBase? Bob)

Attachments (2)

ClassUtil.java.diff (863 bytes) - added by base 16 years ago.
ClassUtil?.java diff
JarClassLoader.java.diff (457 bytes) - added by base 16 years ago.
JarClassLoader?.java diff

Download all attachments as: .zip

Change History (9)

Changed 16 years ago by base

Attachment: ClassUtil.java.diff added

ClassUtil?.java diff

Changed 16 years ago by base

Attachment: JarClassLoader.java.diff added

JarClassLoader?.java diff

comment:1 Changed 16 years ago by Nicklas Nordborg

Component: webcore
Owner: changed from Johan Enell to Nicklas Nordborg

Thanks for the diffs. Strange though that it worked before 2.2.2. The affected code in the files have not changed for more than a year ago. I guess it is something outside of BASE that has changed.

comment:2 Changed 16 years ago by base

Hi Nicklas.

Your comments prompted me to look again at my installation notes... Ignore some of my initial comments. It looks like I failed to compile 2.2.1 with jdk 1.6.0, and reverted to 1.5.0 (and I think it then deployed ok on tomcat running under 1.6.0). My notes are not clear about what worked/didn't work for 2.1.x

The fix seems ok so far (I just clicked through from experiment to labelled extract on the web client) but I'll keep testing. Of course it may not compile under 1.5.0 now - I haven't tested that.

Hope you don't mind FYIs like this in your Trac system. Let me know if the dev mailing list is a better venue.

cheers, Bob.

comment:3 Changed 16 years ago by Nicklas Nordborg

Milestone: BASE 2.4

Not at all. It is good to have them in the Trac so we don't loose the information. It's even better when there are code fixes as well :)

comment:4 Changed 16 years ago by Jari Häkkinen

Milestone: BASE 2.4BASE 2.3

Milestone BASE 2.4 deleted

comment:5 Changed 15 years ago by Jari Häkkinen

Priority: minorcritical

comment:6 Changed 15 years ago by Nicklas Nordborg

Status: newassigned

comment:7 Changed 15 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

(In [3459]) Fixes #567

Note: See TracTickets for help on using tickets.