Opened 8 years ago

Closed 8 years ago

#1812 closed defect (fixed)

Fix filtering on biowell/well columns

Reported by: Nicklas Nordborg Owned by: olle
Priority: major Milestone: BASE 3.3
Component: web Version:
Keywords: Cc:

Description

Ever since the beginning of BASE 2, biowell and well coordinates have been stored as 0-based numerical values. In tickets #1281 and #1282, the GUI was updated to convert and display real-world coordinates instead (eg A1 instead of 0,0). The filter functionality in list pages for the 'row' coordinate (A-Z) was modified to a drop-down list to make it easier for user to filter on the wanted row. The filter functionality for the 'column' coordinate was, for some reason, not changed and is now a bit confusing. Filtering on '0' will display '1' and so on.

The filter for the 'column' column should be changed to dropdown list which allows the user to select the actually displayed values and use the underlying values when filtering. The drop-down list should contain numbers from 1 to the highest value specified by any Plate geometry (but a sensible limit should be applied).

Change History (6)

comment:1 Changed 8 years ago by Nicklas Nordborg

Milestone: BASE 3.2.5BASE 3.3

comment:2 Changed 8 years ago by Nicklas Nordborg

So far I have found the following places which display plate coordinates in a list:

  • Samples list page
  • Extracts list page
  • Bioplates single-item view / Wells tab
  • Biomaterial lists single-item view / Members tab
  • Array design single-item view / Features tab
  • Raw bioassays single-item view / Raw data tab
  • Plate single-item view / Wells tab

comment:3 Changed 8 years ago by olle

Owner: changed from everyone to olle
Status: newassigned

Ticket accepted.

comment:4 Changed 8 years ago by olle

Design description:

  • Filter functionality in list pages for the 'column' coordinate (1-...) as a drop-down list will be modeled after that for the 'row' coordinate, except that column values are numerical and row values are in alphabetic notation (A-Z).
  • Drop-down filter lists for both row and column should contain values from the lowest possible to the highest value specified by any plate geometry, or a preset sensible limit. The limit is set to 255 for both rows and columns.

JSP files controlling the web pages of interest:

Web page JSP file
Samples list page www/biomaterials/samples/list_samples.jsp
Extracts list page www/biomaterials/extracts/list_extracts.jsp
Bioplates single-item view / Wells tab www/biomaterials/bioplates/wells/list_biowells.jsp
Biomaterial lists single-item view / Members tab www/biomaterials/lists/members/list_members.jsp
Array design single-item view / Features tab www/lims/arraydesigns/features/list_features.jsp
Raw bioassays single-item view / Raw data tab www/views/rawbioassays/rawdata/list_rawdata.jsp
Plate single-item view / Wells tab www/lims/plates/wells/list_wells.jsp
Last edited 8 years ago by olle (previous) (diff)

comment:5 Changed 8 years ago by olle

(In [6482]) Refs #1812. Biowell and well column filters changed to drop-down lists containing real-world coordinates, i.e. starting from 1 instead of 0. In addition, both the row and column filter menus are limited to 255 items, if a geometry with more rows or columns should have been defined:

  1. Filter functionality in list pages for the 'column' coordinate (1-...) as a drop-down list is modeled after that for the 'row' coordinate, except that column values are numerical and row values are in alphabetic notation (A-Z).
  2. Drop-down filter lists for both row and column will contain values from the lowest possible to the highest value specified by any plate geometry, or a preset limit of 255 items.

JSP files controlling the web pages of interest:

Web page JSP file
Samples list page www/biomaterials/samples/list_samples.jsp
Extracts list page www/biomaterials/extracts/list_extracts.jsp
Bioplates single-item view / Wells tab www/biomaterials/bioplates/wells/list_biowells.jsp
Biomaterial lists single-item view / Members tab www/biomaterials/lists/members/list_members.jsp
Array design single-item view / Features tab www/lims/arraydesigns/features/list_features.jsp
Raw bioassays single-item view / Raw data tab www/views/rawbioassays/rawdata/list_rawdata.jsp
Plate single-item view / Wells tab www/lims/plates/wells/list_wells.jsp

comment:6 Changed 8 years ago by olle

Resolution: fixed
Status: assignedclosed

Ticket closed since the listed biowell and well column filters have been changed to drop-down lists containing real-world coordinates, i.e. starting from 1 instead of 0.

Note: See TracTickets for help on using tickets.