Ticket #742 (closed enhancement: fixed)
Refactor BioAssaySetExporter
| Reported by: | nicklas | Owned by: | nicklas |
|---|---|---|---|
| Priority: | minor | Milestone: | BASE 2.12 |
| Component: | coreplugins | Version: | |
| Keywords: | Cc: |
Description
There has been requests on the mailing list to be able to subclass the BioAssaySetExporter? for different purposes. It is currently a problem since most of the methods are private and can't be called/overridden from a subclass.
For more information see: http://www.mail-archive.com/basedb-devel@lists.sourceforge.net/msg00038.html and ticket #741.
Change History
comment:3 follow-up: ↓ 6 Changed 3 years ago by nicklas
- Status changed from new to assigned
- Owner changed from everyone to nicklas
- Milestone changed from BASE 2.x+ to BASE 2.12
There is now a new use case in http://baseplugins.thep.lu.se/ticket/212. At the same time I think we should move the MeV TDMS export into the MeV extension. To avoid backwards compatibility issues I think we should deprecate the entire BioAssaySetExporter class and start fresh with a new structure.
comment:4 Changed 3 years ago by nicklas
(In [4925]) References #742: Refactor BioAssaySetExporter?
The new exporter structure is in place. The old export and plug-in has not been touched yet.
comment:5 Changed 3 years ago by nicklas
(In [4926]) References #742: Refactor BioAssaySetExporter?
Added some more support functionality into superclasses.
comment:6 in reply to: ↑ 3 Changed 3 years ago by jari
Replying to nicklas:
There is now a new use case in http://baseplugins.thep.lu.se/ticket/212. At the same time I think we should move the MeV TDMS export into the MeV extension. To avoid backwards compatibility issues I think we should deprecate the entire BioAssaySetExporter class and start fresh with a new structure.
I concur, deprecate BioAssaySetExporter.
comment:7 Changed 3 years ago by nicklas
(In [4928]) References #742: Refactor BioAssaySetExporter?
The new BASEfile exporter plug-in is in place. The BioAssaySetExporter? has been deprecated but no changes have yet been made to code that uses it. The installation will unshare the BioAssaySetExporter? if upgrading and doesn't install it as a plug-in in a new installation. Also fixed DynamicPositionQuery? so that it handles extra values properly (=support for automatic joins to the needed tables).
comment:8 Changed 3 years ago by nicklas
(In [4930]) References #742: Refactor BioAssaySetExporter?
Base1PluginExecuter now uses the new exporter code.
comment:9 Changed 3 years ago by nicklas
(In [4931]) References #742: Refactor BioAssaySetExporter?
This fixes the web services by depracating the on-the-fly export and adding new methods for downloading pre-generated BASE files.
comment:10 Changed 3 years ago by nicklas
(In [4932]) References #742: Refactor BioAssaySetExporter?
Removed references in the documentation to BioAssaySetExporter?.
comment:11 Changed 3 years ago by nicklas
- Status changed from assigned to closed
- Resolution set to fixed
This seems to work fine now. Both MeV exporters are in place and working.
