Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#401 closed defect (fixed)

Filter plugin - failed to correctly apply filter on M values

Reported by: Johan Vallon-Christersson Owned by: Nicklas Nordborg
Priority: major Milestone: BASE 2.0.3
Component: coreplugins Version:
Keywords: Cc:

Description

When applying a filter to create a filtered bioassay set using the following parameters:

Plugin & parameters Plugin Formula filter plugin Keep spots 4 Filter expression log2(ch(1) / ch(2)) > 1

Spots with M values < 1 are kept.

Change History (3)

comment:1 by Nicklas Nordborg, 18 years ago

Component: web → coreplugins
Owner: changed from Johan Enell to Nicklas Nordborg
Status: new → assigned

This seems certainly to be true. The buggy code is located in the includeSpot() method of IncludeExcludeFilter.java. This method doesn't have enough information to determine if a spot should be included or not and the current code is a bit strange.

comment:2 by Nicklas Nordborg, 18 years ago

Resolution: → fixed
Status: assigned → closed

(In [2777]) Fixes #401: Filter plugin - failed to correctly apply filter on M values

!!!DO NOT MERGE THIS FIX INTO THE TRUNK. IT HAS BEEN FIXED SEPARATELY!!!

comment:3 by Nicklas Nordborg, 18 years ago

(In [2778]) Fixes #401: Filter plugin - failed to correctly apply filter on M values

For the trunk only. Changeset [2777] fixes this bug for the 2.0.2 branch.

Note: See TracTickets for help on using tickets.