Opened 17 years ago

Closed 17 years ago

#397 closed task (fixed)

Use the FindBugs program to check the BASE 2 code

Reported by: Nicklas Nordborg Owned by: Martin Svensson
Priority: critical Milestone: BASE 2.2
Component: core Version: trunk
Keywords: Cc:

Description

I recently tested the FindBugs (http://findbugs.sourceforge.net/) program on the BASE 2 code. It found some strange code at various places. Some of the things it found needs to be corrected.

Change History (13)

comment:1 by Jari Häkkinen, 17 years ago

Milestone: BASE 2.x+BASE 2.2

comment:2 by Nicklas Nordborg, 17 years ago

Owner: changed from Nicklas Nordborg to Martin Svensson

comment:3 by Martin Svensson, 17 years ago

Status: newassigned

comment:4 by Martin Svensson, 17 years ago

(In [2866]) References #397 Null pointer dereference

comment:5 by Martin Svensson, 17 years ago

(In [2867]) References #397 The index of the parameters in PreparedStatement begins at 1 according to javadoc.

comment:6 by Martin Svensson, 17 years ago

(In [2870]) References #397 Method may fail to close database resource

comment:7 by Martin Svensson, 17 years ago

(In [2871]) References #397 Dead store to local variable

comment:8 by Martin Svensson, 17 years ago

(In [2872]) References #397 'Dead local store' fixed

comment:9 by Martin Svensson, 17 years ago

(In [2873]) References #397 Dead local store.

comment:10 by Martin Svensson, 17 years ago

(In [2874]) References #397 Checks that the whole offset was skipped.

comment:11 by Martin Svensson, 17 years ago

(In [2876]) References #397 Removed fields that are not used.

comment:12 by Martin Svensson, 17 years ago

(In [2884]) References #397 Unused fields and exception handling.

comment:13 by Martin Svensson, 17 years ago

Resolution: fixed
Status: assignedclosed

Things reported by FindBugs with high and normal priority have been fixed/checked. While Findbugs still is a bit unstable with saving project/analysis and so on the things with priority Low will not be handled right now.

Note: See TracTickets for help on using tickets.