Opened 6 years ago
Closed 6 years ago
#2151 closed enhancement (fixed)
Pre-compile all JSP pages before releases
Reported by: | Nicklas Nordborg | Owned by: | Nicklas Nordborg |
---|---|---|---|
Priority: | major | Milestone: | BASE 3.15 |
Component: | build | Version: | |
Keywords: | Cc: |
Description
The bug in #2143 got me thinking that it would be nice if there was a way to check that all JSP files compile without error before making a release. We already have the CompileAll servlet in web.xml which can do this but we get no information about code that is using deprecated methods or other warnings.
To my surprise I also found a very old commit [1990] which added an ant task for compiling the JSP pages. It turns out that it is still present in build.xml under the name web.jsp
. It still works if adding strictQuoteEscaping="false"
to the <jasper2>
command.
However, I think we should check the current Tomcat documentation and see if we can improve it.
https://tomcat.apache.org/tomcat-8.5-doc/jasper-howto.html#Web_Application_Compilation
We should also add a point in the release instructions to perform this check.
Change History (15)
comment:1 by , 6 years ago
Owner: | set to |
---|---|
Status: | new → accepted |
comment:2 by , 6 years ago
comment:15 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
In 7600: