Opened 8 years ago
Closed 8 years ago
#2001 closed enhancement (fixed)
Annotations should only replace existing values when the new values are different
| Reported by: | Nicklas Nordborg | Owned by: | Nicklas Nordborg |
|---|---|---|---|
| Priority: | critical | Milestone: | BASE 3.8 |
| Component: | core | Version: | |
| Keywords: | Cc: |
Description
The current implementation simple replaces the values without checking the old ones.
Change History (4)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
| Component: | coreplugins → core |
|---|---|
| Summary: | The annotation importer should only replace existing values when the new values are different → Annotations should only replace existing values when the new values are different |
comment:3 by , 8 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
All tests have now been completed successfully.
Note:
See TracTickets
for help on using tickets.
(In [7120]) References #2001: The annotation importer should only replace existing values when the new values are different
It turned out to be easier to make this change in the core instead of in the plug-in. The
Annotation.setValue()andAnnotation.setValues()method has been deprecated and replaced withAnnotation.setValueIfDifferent()andAnnotation.setValuesIfDifferent()that only update the values if they are not the same as the current values. Both methods return a boolean with TRUE indicating that a change was made. The old methods simply calls the new methods except that they don't return any value.