Opened 13 years ago

Closed 13 years ago

#1567 closed defect (fixed)

Stale platform name in raw bioassay "raw data type" list filter

Reported by: base Owned by: Nicklas Nordborg
Priority: trivial Milestone: BASE 2.16.2
Component: web Version:
Keywords: Cc:


I was testing a new platform, and renamed it, but the old name persisted in the drop-down filter in the aforementioned raw bioassay "raw data type" list filter. I tried reloading permissions and logging out and back in again. Only a server restart seemed to fix it.

Not a major problem, but a bit confusing for people trying to figure out if they need a new platform or raw data type etc.

Thanks, Bob.

Change History (3)

comment:1 by Nicklas Nordborg, 13 years ago

A file-only platform also generates a raw data type behind the scenes for backwards compatibility reasons. Some information (eg. id and name) is copied from the platform to the raw data type. It would not bee too difficult to keep the names synchronized, but I am bit worried about side effects if the name of a raw data type is changed. The name it is used in the compareTo() method which may cause some set implementations to stop working if the name changes.

comment:2 by Nicklas Nordborg, 13 years ago

Milestone: BASE 2.16.2
Owner: changed from everyone to Nicklas Nordborg
Priority: minortrivial
Status: newassigned

I have been thinking a bit more about this and my conclusion is that it was a "bad" design choice to implement the compareTo() method in the RawDataType class instead of using a separate Comparator implementation. It's too late to remove the compareTo() method but it should be possible to make it independent of the name. This will not break 'Set' implementations. The only side-effect is that the default sort ordering is going to be different, but this can easily be fixed were sorting by name is required (eg. drop-down lists in the gui) by implementing a separate Comparator.

comment:3 by Nicklas Nordborg, 13 years ago

Resolution: fixed
Status: assignedclosed

(In [5545]) Fixes #1567: Stale platform name in raw bioassay "raw data type" list filter

Note: See TracTickets for help on using tickets.