Opened 16 years ago

Closed 16 years ago

#119 closed defect (fixed)

can't annotate sample in base 2 demo server

Reported by: r.maccallr@… Owned by: Martin Svensson
Priority: critical Milestone: BASE 2.0 RC2
Component: core Version: RC1
Keywords: Cc:

Description

Hi Jari/others,

When I'm using my guest509 username on the base2 demo server, I can create a new Sample, but I can't give it an Annotation. I'm not trying to create a new Annotation type, I'm just assigning one of the existing annotations and I get this error.

Permission denied On page /base2demo/biomaterials/samples/index.jsp Permission denied: Not allowed to create Annotation set[new]

maybe it's just a permission thing, rather than a bug, but I didn't want to ignore it completely - hence this bug report!

thanks,

Bob.

Change History (10)

comment:1 Changed 16 years ago by Jari Häkkinen

Owner: changed from Gregory Vincic to Jari Häkkinen
Status: newassigned

comment:2 Changed 16 years ago by Jari Häkkinen

Owner: changed from Jari Häkkinen to Johan Enell
Status: assignednew

comment:3 Changed 16 years ago by Johan Enell

Component: webmigrate
Status: newassigned

Annotations isnt migrated correct. Permission r in base1 must be translated to ru in base2. Investigating if this is true for all items.

comment:4 Changed 16 years ago by Johan Enell

Milestone: BASE 2.0 RC2
Version: RC1

comment:5 Changed 16 years ago by Nicklas Nordborg

Component: migratecore
Priority: majorcritical

This is probably a bug in the AnnotationSet?.initPermissions method. The current implementation seems to only works if the AnnotationSet? is already saved in the database. In older code the AnnotationSet? was created behind the scenes when needed (and not subject to permission checks), but that is not the case anymore. Since there is no explicit way of setting permissions for AnnotationSet:s (and there shouldn't be), the bug in the initPermissions method results in that only the root user can create the first annotation. Once there is an annotation the code is correct and it shouldn't be a problem for other users to change the annotation or create new annotations.

comment:6 Changed 16 years ago by Jari Häkkinen

Priority: criticalblocker

comment:7 Changed 16 years ago by Jari Häkkinen

Priority: blockercritical

comment:8 Changed 16 years ago by Nicklas Nordborg

Owner: changed from Johan Enell to Martin Svensson
Status: assignednew

comment:9 Changed 16 years ago by Martin Svensson

Status: newassigned

comment:10 Changed 16 years ago by Martin Svensson

Resolution: fixed
Status: assignedclosed

(In [2098]) Fixes #119. Can't annotate sample in base 2 demo server

Note: See TracTickets for help on using tickets.