#1780 closed defect (fixed)
Copy-transformation icon should be disabled if logged in user doesn't have USE permission
Reported by: | Nicklas Nordborg | Owned by: | olle |
---|---|---|---|
Priority: | minor | Milestone: | BASE 3.2.4 |
Component: | web | Version: | |
Keywords: | Cc: |
Description
Related to #1779, but since no selection of plug-ins is taking place here, the copy will fail with 'permission denied' message. Before placing the 'copy' icon in the GUI it should be checked that user is actually allowed to use the plug-in + config.
Change History (7)
comment:1 by , 11 years ago
Owner: | changed from | to
---|
comment:2 by , 11 years ago
Status: | new → assigned |
---|
comment:3 by , 11 years ago
Example of use case:
- The copy icon () in
www/images/copy.png
is displayed in column "Tools
" at the right end of a row of an analysis sub-tree table, e.g.Experiments
->Experiment A
, tab "Bioassay sets
". If a plug-in has been used to transform the bioassay set, a new leaf is created named after the plug-in, and a child leaf with the result of the transformation. If the copy icon for a transformation is clicked, a configuration pop-up dialog for the transformation should appear. However, if the user doesn't haveUSE
permission for the plug-in or its configuration, the dialog will only contain the 'permission denied
' message. - A common example of when
USE
permission exists for a plug-in, but not for its configuration, is BASE 1 plug-ins. In BASE version 2 and up, BASE 1 plug-ins are run as configurations of the BASE 1 plug-in executor, and USE permission is often granted for the latter, but not always for all BASE 1 plug-ins.
comment:4 by , 11 years ago
Problem discussion:
- The 'copy' icon for a transformation is placed in the bioassayset analysis tree GUI by JSP script
www/views/experiments/bioassaysets/analysis_tree.jsp
, provided a job and an interactive plug-in exist, but no check that the user has permission to use the plug-in or its configuration is performed. - The 'copy' button in the properties tool bar for a transformation is created by JSP script
www/views/experiments/transformations/view_transformation.jsp
, providedWRITE
permission for the transformation exists, but no check that the user has permission to use the plug-in or its configuration is performed.
Suggested fix:
- JSP script
www/views/experiments/bioassaysets/analysis_tree.jsp
should be updated to only add a 'copy' link, if the user has permission to use the plug-in and its configuration. The user might not haveREAD
permission for a plug-in, which must be considered when trying to obtain the plug-in configuration. A better solution than omitting the 'copy' link, would have been to display an icon for a disabled action, but this is left for a future update. - JSP script
www/views/experiments/transformations/view_transformation.jsp
should be updated to check if the user has permission to use the plug-in and its configuration, and disable the 'copy' button in the properties tool bar for the transformation, if the permissions are insufficient.
comment:5 by , 11 years ago
(In [6344]) Refs #1780. Refs #1779. The option to copy a transformation is now disabled, if insufficient permissions exist to perform it:
- JSP script
www/views/experiments/bioassaysets/analysis_tree.jsp
is updated to only add a 'copy' link, if the user has permission to use the plug-in and its configuration. The user might not haveREAD
permission for a plug-in, which is considered when trying to obtain the plug-in configuration. A better solution than omitting the 'copy' link, would have been to display an icon for a disabled action, but this is left for a future update. - JSP script
www/views/experiments/transformations/view_transformation.jsp
is updated to check if the user has permission to use the plug-in and its configuration, and disable the 'copy' button in the properties tool bar for the transformation, if the permissions are insufficient.
comment:6 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Ticket closed as the requested functionality has been added.
comment:7 by , 11 years ago
Note:
See TracTickets
for help on using tickets.
Ticket accepted.