Opened 8 months ago

Closed 6 months ago

#2058 closed enhancement (fixed)

Item overview is not working when going from extract to derived bioassay

Reported by: nicklas Owned by: nicklas
Priority: major Milestone: BASE 3.11
Component: core Version:
Keywords: Cc:

Description

It is possible to create an item hierarchy that goes directly from extract to derived bioassay without a physical bioassay in-between.

The item overview functionality has problem with this though since it has not considered this case. It only supports going from extract to physical bioassay or raw bioassay.

It should be relatively easy to implement the missing link.

Change History (7)

comment:1 Changed 8 months ago by nicklas

  • Owner changed from everyone to nicklas
  • Status changed from new to assigned

comment:2 Changed 8 months ago by nicklas

Hmm... it was a lot more complicated than what I first believed...

There might be an intermediary extract (eg. a pool) that is holding the link.

... -> Library -> PooledLibrary -> ... -> DerivedBioAssay -> RawBioAssay
                                          └> Library         └>Library

So when looking for derived bioassays to load, we simply can't look att first extract we find upstreams (which is the pooled library) since the back-link may go to any extract in the upstreams chain. We need to load all related extract that we can find, and then we can load the correct derived bioassay.

Note that this seems to be implemented already, but only if we start high enough up in the item chain (eg. at the Library level or higher). If we start at the pooled library level, no derived (or raw) bioassays are loaded in the overview.

comment:3 Changed 8 months ago by nicklas

(In [7301]) References #2058: Item overview is not working when going from extract to derived bioassay

This should fix the first part of the problem so that forward-loading links from extract to derived bioassays are considered.

This will load derived bioassays that has no parent derived bioassays and are linked directly to the extract. Note that there is no need to check other parents items here since if they are included in the overview tree the derived bioassay would have been included on that level instead.

comment:4 Changed 8 months ago by nicklas

(In [7302]) References #2058: Item overview is not working when going from extract to derived bioassay

This should hopefully fix the second problem with back-links going to a parent extract higher up in the overview tree. The same fix was needed for both derived and raw bioassays.

comment:5 Changed 8 months ago by nicklas

(In [7303]) References #2058: Item overview is not working when going from extract to derived bioassay

The second fix did not work since it was going up and down among the extracts causing derived bioassays for other libraries in the pool to be loaded when they should not be loaded.

This fix changes the code so that only parent extracts from the root node are considered when loading the derived and raw bioassays.

comment:6 Changed 8 months ago by nicklas

(In [7304]) References #2058: Item overview is not working when going from extract to derived bioassay

The node cache must be disabled for now. There is a problem when, for example, when two or more libraries belonging to the same pool are in the same overview. If nodes are cached, contents below (or above) the pool will always follow the same path which is only correct for the first path opened:

Lib1 -> Pool1 -> ... -> Merged1
Lib2 -> Pool1 -> ... -> Merged1 

comment:7 Changed 6 months ago by nicklas

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.