Opened 7 months ago

Closed 6 months ago

#2047 closed defect (fixed)

The "Share" and "Delete" icon in table listing seems to always be enabled

Reported by: nicklas Owned by: nicklas
Priority: trivial Milestone: BASE 3.10
Component: web Version:
Keywords: Cc:

Description

Most GUI items in BASE appear dimmed and in grayscale if the the logged in user doesn't have permission to use the function. However, in table listing, the icon indicating that items are shared seems to always be active even if the logged in user doesn't have permission to change the sharing. Hovering with the mouse indicates that it can be clicked, but actually clicking doesn't make anything happen. The same goes for the "Delete" icon.

Change History (4)

comment:1 Changed 7 months ago by nicklas

I think this used to work before but got broken by all changes when redesigning the GUI in #1655 and getting rid of all inline javascript in #1712 and maybe some other tickets as well.

Fixing it should be as simple as modifying all list pages and change:

subclass="<%=sharePermission ? "table-share-item" : null %>"

to

subclass="<%=sharePermission ? "table-share-item" : "disabled" %>"

and similar for fixing the "Delete" icon.

comment:2 Changed 6 months ago by nicklas

  • Owner changed from everyone to nicklas
  • Status changed from new to assigned

comment:3 Changed 6 months ago by nicklas

(In [7268]) References #2047: The "Share" and "Delete" icon in table listing seems to always be enabled

The "Share" icon has been fixed.

comment:4 Changed 6 months ago by nicklas

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7269]) Fixes #2047: The "Share" and "Delete" icon in table listing seems to always be enabled

The "Delete" icon has been fixed.

Note: See TracTickets for help on using tickets.