Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1932 closed enhancement (fixed)

Improve display of selection list in table filters

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: minor Milestone: BASE 3.5
Component: web Version:
Keywords: Cc:

Description

There are a few issues:

  • The selected option is not visible if the list of options is long. Mainly a problem with "Item lists" if the number of lists is long. Could also be an issue with enumerated annotation types having lots of options. Would be good if the list could auto-scroll so that the first selected option is always visible.
  • The '<>' checkbox in radio-type selection should be clickable and toggle the checkbox.
  • When the selection list is the last column in the table it may risk being drawn outside the visible the browser window. The browser displays a scrollbar at the bottom so it is possible to scroll the list into view, but this is relly annoying and it would be nice if the dropdown was visible to begin with.
  • Add a 'clear filter' icon in the drop-down 'header'. There should be enough space for this in next to the 'ok' icon.

Change History (14)

comment:1 Changed 6 years ago by Nicklas Nordborg

Owner: changed from everyone to Nicklas Nordborg
Status: newassigned

comment:2 Changed 6 years ago by Nicklas Nordborg

(In [6821]) References #1932: Improve display of selection list in table filters

Makes '<>' clickable and linked to the checkbox by wrapping it with <label> tag.

comment:3 Changed 6 years ago by Nicklas Nordborg

(In [6822]) References #1932: Improve display of selection list in table filters

When opening the drow-down list it automatically scrolls so that the first selected option is visible.

comment:4 Changed 6 years ago by Nicklas Nordborg

(In [6823]) References #1932: Improve display of selection list in table filters

Trying to handle the problem with positioning the dropdown when the column is near the right side of the browser window. Due to horizontal scrolling of the parent table it is lot more complicated than simply checking the coordinate. The strategy now is to right-align the dropdown with the filter input field and then to re-position the scrollbar if it is still overflows to the right.

comment:5 Changed 6 years ago by Nicklas Nordborg

(In [6824]) References #1932: Improve display of selection list in table filters

Added 'clear filter' icon to dropdown list.

comment:6 Changed 6 years ago by Nicklas Nordborg

(In [6826]) References #1932: Improve display of selection list in table filters

Fixed list options containing '<', '>' or '&' so that they don't end up encoded as '&lt;', etc. in the filter display.

comment:7 Changed 6 years ago by Nicklas Nordborg

(In [6827]) References #1932: Improve display of selection list in table filters

Several changes to make it possible to select between equals and no-equals comparison for multi-selection lists. The 'select-all' icon has been removed but the same functionality is available on the 'x selected' text instead.

A new icon '=' or '≠' replaces the 'select-all' icon and is used to toggle between equals and not-equals comparison.

Lists with a 'none' option experience the same behaviour as described in #1205 and also an additional twist depending on if the 'none' option is select or not. Maybe we should open #1205 again but we need think about how it should work when there are multiple options selected.

comment:8 Changed 6 years ago by Nicklas Nordborg

(In [6828]) References #1932: Improve display of selection list in table filters

Fixes an issue that caused the dropdown to disappear on the first click if it was not opened with the dropdownicon.

comment:9 Changed 6 years ago by Nicklas Nordborg

(In [6829]) References #1932: Improve display of selection list in table filters

Change icon for the 'clear filter' action so that it is consistent with the other 'clear filter row' icon.

comment:10 Changed 6 years ago by Nicklas Nordborg

(In [6830]) References #1932: Improve display of selection list in table filters

Fixes 'not-equal' filters to also return items with 'null' value unless 'null' was included in the filter. This should work for regular item properties and single-valued annotations. It's unclear what happens when searching in collections (including multi-valued annotations) since that probably require a more complex approach (see #1895).

comment:11 Changed 6 years ago by Nicklas Nordborg

(In [6831]) References #1932: Improve display of selection list in table filters

Detecting window resize events and moving active dropdown to the new position.

comment:12 Changed 6 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

comment:13 Changed 6 years ago by Nicklas Nordborg

(In [6835]) References #1932: Improve display of selection list in table filters

Use images for '=' and '≠' instead of text on a background since that will avoid problems with exact alignment on the pixel level.

comment:14 Changed 6 years ago by Nicklas Nordborg

(In [6836]) References #1932: Improve display of selection list in table filters

Modifed the 'select/deselect' all function to toggle unless CTRL, ALT or SHIFT is used to make this behave the same as the other list selection (see #1935).

Note: See TracTickets for help on using tickets.