Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1773 closed enhancement (fixed)

Tag items should be annotatable

Reported by: Nicklas Nordborg Owned by: olle
Priority: major Milestone: BASE 3.3
Component: core Version:
Keywords: Cc:

Description


Change History (8)

comment:1 Changed 7 years ago by olle

Owner: changed from everyone to olle

comment:2 Changed 7 years ago by olle

Status: newassigned

Ticket accepted.

comment:3 Changed 7 years ago by olle

Traceability node:

  • Ticket #1310 (Annotations for protocols) covers making Protocol items annotatable.
  • Ticket #1771 (Hardware items should be annotatable) covers making Hardware items annotatable.
  • Ticket #1772 (Software items should be annotatable) covers making Software items annotatable.

comment:4 Changed 7 years ago by olle

Design discussion:

  • The design for this update will be based on that for Ticket #1771 (Hardware items should be annotatable) and Ticket #1772 (Software items should be annotatable).
  • Support for annotatable Tag items will include the following parts:
    a. Basic support for adding annotations to Tag items.
    b. Adding an "Annotations" tab to the page for inspecting a Tag item, and displaying the annotations.
    c. Adding an "Annotations" tab to the edit dialog for a Tag item, and making it possible to edit annotations.
    d. For an item that can have an attached Tag item, making annotations to the latter appear in the tree node for the overview of that item.
    e. For an item that can have an attached Tag item, making annotations to the latter appear in the "Inherited annotations" tab of the edit dialog for that item.
  • Normally the database schema version should also be updated, since step (a.) above adds new database columns. However, this will not be done here, as the database schema version has already been updated in connection with making Hardware items annotatable in Ticket #1771, and that change will be included in the same release as this one. (The same procedure was followed for Ticket #1772, when making Software items annotatable.)
Version 0, edited 7 years ago by olle (next)

comment:5 Changed 7 years ago by olle

Design implementation:

The different parts in adding support for annotatable Tag items will involve updates to the following files:

  1. Basic support for adding annotations to Tag items:

    Tag.java in base3/src/core/net/sf/basedb/core/ and
    TagData.java in base3/src/core/net/sf/basedb/core/data/.

  2. Adding an "Annotations" tab to the page for inspecting a Tag item, and displaying the annotations:

    JavaScript tags.js in base3/www/biomaterials/tags/
    JSP script list_tags.jsp in base3/www/biomaterials/tags/
    JSP script view_tag.jsp in base3/www/biomaterials/tags/

  3. Adding an "Annotations" tab to the edit dialog for a Tag item, and making it possible to edit annotations:

    JSP script edit_tag.jsp in base3/www/biomaterials/tags/
    JavaScript tags.js in base3/www/biomaterials/tags/
    JSP script index.jsp in base3/www/biomaterials/tags/
    JavaScript main.js in base3/www/include/scripts/ (for making edit dialog larger).

  4. For an item that can have an attached Tag item, making annotations to the latter appear in the tree node for the overview of that item:

    TagLoader.java in base3/src/core/net/sf/basedb/util/overview/loader/

  5. For an item that can have an attached Tag item, making annotations to the latter appear in the "Inherited annotations" tab of the edit dialog for that item:

    Extract.java in base3/src/core/net/sf/basedb/core/
    JavaScript extracts.js in base3/www/biomaterials/extracts/

comment:6 Changed 7 years ago by olle

(In [6335]) Refs #1773. Support for annotatable Tag items added.

comment:7 Changed 7 years ago by olle

Resolution: fixed
Status: assignedclosed

Ticket closed as the requested functionality has been added.

comment:8 Changed 7 years ago by olle

(In [6362]) Refs #1773. Page for inspecting a Tag item updated by adding a "Change history" tab, and displaying the changes:

  1. JavaScript tags.js in base3/www/biomaterials/tags/ updated in function initPage() for pageId equal to view-page to add a tab active listener for history data.
  2. JSP script view_tags.jsp in base3/www/biomaterials/tags/ updated in HTML section to add a "Change history" tab.
Note: See TracTickets for help on using tickets.