Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1772 closed enhancement (fixed)

Software items should be annotatable

Reported by: Nicklas Nordborg Owned by: olle
Priority: major Milestone: BASE 3.3
Component: core Version:
Keywords: Cc:

Description


Change History (8)

comment:1 Changed 7 years ago by olle

Owner: changed from everyone to olle

comment:2 Changed 7 years ago by olle

Status: newassigned

Ticket accepted.

comment:3 Changed 7 years ago by olle

Traceability node:

  • Ticket #1310 (Annotations for protocols) covers making Protocol items annotatable.
  • Ticket #1771 (Hardware items should be annotatable) covers making Hardware items annotatable.

comment:4 Changed 7 years ago by olle

Design discussion:

  • The design for this update will be based on that for Ticket #1771 (Hardware items should be annotatable).
  • Support for annotatable Software items will include the following parts:
    a. Basic support for adding annotations to Software items.
    b. Adding an "Annotations" tab to the page for inspecting a Software item, and displaying the annotations.
    c. Adding an "Annotations" tab to the edit dialog for a Software item, and making it possible to edit annotations.
    d. For an item that can have an attached Software item, making annotations to the latter appear in the tree node for the overview of that item.
    e. For an item that can have an attached Software item, making annotations to the latter appear in the "Inherited annotations" tab of the edit dialog for that item.
  • Normally the database schema version should also be updated, since step (a.) above adds new database columns. However, this will not be done here, as the database schema version has already been updated in connection with making Hardware items annotatable in Ticket #1771, and that change will be included in the same release as this one.
Last edited 7 years ago by olle (previous) (diff)

comment:5 Changed 7 years ago by olle

Design implementation:

The different parts in adding support for annotatable Software items will involve updates to the following files:

  1. Basic support for adding annotations to Software items:

    Software.java in base3/src/core/net/sf/basedb/core/ and
    SoftwareData.java in base3/src/core/net/sf/basedb/core/data/.

  2. Adding an "Annotations" tab to the page for inspecting a Software item, and displaying the annotations:

    JavaScript software.js in base3/www/admin/software/
    JSP script list_software.jsp in base3/www/admin/software/
    JSP script view_software.jsp in base3/www/admin/software/

  3. Adding an "Annotations" tab to the edit dialog for a Software item, and making it possible to edit annotations:

    JSP script edit_software.jsp in base3/www/admin/software/
    JavaScript software.js in base3/www/admin/software/
    JSP script index.jsp in base3/www/admin/software/
    JavaScript main.js in base3/www/include/scripts/ (for making edit dialog larger).

  4. For an item that can have an attached Software item, making annotations to the latter appear in the tree node for the overview of that item:

    SoftwareLoader.java in base3/src/core/net/sf/basedb/util/overview/loader/

  5. For an item that can have an attached Software item, making annotations to the latter appear in the "Inherited annotations" tab of the edit dialog for that item:

    DerivedBioAssay.java in base3/src/core/net/sf/basedb/core/
    JavaScript bioassays.js in base3/www/views/derivedbioassays/
    RawBioAssay.java in base3/src/core/net/sf/basedb/core/
    JavaScript bioassays.js in base3/www/views/rawbioassays/

comment:6 Changed 7 years ago by olle

(In [6334]) Refs #1772. Support for annotatable Software items added.

comment:7 Changed 7 years ago by olle

Resolution: fixed
Status: assignedclosed

Ticket closed as the requested functionality has been added.

comment:8 Changed 7 years ago by olle

(In [6361]) Refs #1772. Page for inspecting a Software item updated by adding a "Change history" tab, and displaying the changes:

  1. JavaScript software.js in base3/www/admin/software/ updated in function initPage() for pageId equal to view-page to add a tab active listener for history data.
  2. JSP script view_software.jsp in base3/www/admin/software/ updated in HTML section to add a "Change history" tab.
Note: See TracTickets for help on using tickets.