Opened 11 years ago

Closed 11 years ago

#1360 closed defect (fixed)

Existing annotatation on an item may not be visible/editable in some cases

Reported by: base Owned by: Nicklas Nordborg
Priority: minor Milestone: BASE 2.13
Component: core Version:
Keywords: protocol parameter Cc:

Description (last modified by Nicklas Nordborg)

How to reproduce:

  1. create annotation type AT being protocol parameter and allow it for items of type IT
  2. add protocol parameter PP of type AT to protocol P
  3. create an ITEM of IT type, select protocol P and annotate with protocol parameter PP
  4. remove PP from parameters of protocol PP

The ITEM will still have the annotation of type AT, but it will not be shown in list of ITEM's annotations, so it can't be deleted/altered. Is this desired behavior? Maybe one should not be able to remove protocol parameter if there are items using it?

I have not checked what will happen if instead of (4) one will change/unselect the protocol P for ITEM.

Change History (3)

comment:1 Changed 11 years ago by Nicklas Nordborg

Description: modified (diff)
Milestone: BASE 2.13
Owner: changed from everyone to Nicklas Nordborg
Status: newassigned

This is not the desired behaviour. I think it is something that happens if changes are made to the protocol and/or the annotation type in such a way that the annotation type no longer can be used on new items of the same type. The procedure described above is just one way of many to achive this.

I think that already existing annotations should be visible when editing annotations.

A workaround is to use the "Overview" tab. This will list the existing annotations and will probably also give a warning about the annotation not being a protocol parameter of the used protocol. Use the links on the "Overview" page to edit/remove the annotation. There are several links, but one of them give the same error as in #1361 (Unhandled item: ANNOTATION....).

comment:2 Changed 11 years ago by Nicklas Nordborg

Summary: Can't remove annotatation on item after removing protocol parameter of this annotation type.Existing annotatation on an item may not be visible/editable in some cases

comment:3 Changed 11 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

(In [5074]) Fixes #1360: Existing annotatation on an item may not be visible/editable in some cases

This should make sure that all existing annotations can be viewed and edited. The problem with the "Unhandled item: ANNOTATION..." will be fixed as part of #1361.

Note: See TracTickets for help on using tickets.